Added wrapper with pagination support for room hierarchy endpoint #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror and a wrapper for the GET /v1/rooms/:roomid/hierarchy endpoint
jacks0n9
approved these changes
Nov 4, 2022
sumnerevans
requested changes
Nov 5, 2022
| // when it encounters another space as a child it recurses into that space before returning non-space children. | ||
| // | ||
| // NOTE: Only the roomID is required, the rest of the fields are optional and ignored if left to default values. | ||
| func (cli *Client) Hierarchy(roomID id.RoomID, from string, max_depth int, suggested_only bool, limit int) (resp *RespHierarchy, err error) { |
There was a problem hiding this comment.
Go variables should be camelCase.
Suggested change
| func (cli *Client) Hierarchy(roomID id.RoomID, from string, max_depth int, suggested_only bool, limit int) (resp *RespHierarchy, err error) { | |
| func (cli *Client) Hierarchy(roomID id.RoomID, from string, maxDepth int, suggestedOnly bool, limit int) (resp *RespHierarchy, err error) { |
|
|
||
| type StrippedChildStateEvent struct { | ||
| Content json.RawMessage `json:"content"` | ||
| OriginServerTs int64 `json:"origin_server_ts"` |
There was a problem hiding this comment.
Generally this has been aliased to Timestamp elsewhere in mautrix-go.
Suggested change
| OriginServerTs int64 `json:"origin_server_ts"` | |
| Timestamp int64 `json:"origin_server_ts"` |
| OriginServerTs int64 `json:"origin_server_ts"` | ||
| Sender id.UserID `json:"sender"` | ||
| StateKey string `json:"state_key"` | ||
| Type string `json:"type"` |
There was a problem hiding this comment.
Maybe this needs to be
Suggested change
| Type string `json:"type"` | |
| Type event.Type `json:"type"` |
but I am not quite sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #91