error: remove pointer receiver from Write

Otherwise it can't be chained after WithMessage
mautrix · Sep 12, 2024 · 36ef69b · 36ef69b
1 parent 012aed9
commit 36ef69b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bridgev2/errors.go b/bridgev2/errors.go
@@ -81,8 +81,8 @@ func (re RespError) Is(err error) bool {
 	return errors.Is(err, mautrix.RespError(re))
 }
 
-func (re *RespError) Write(w http.ResponseWriter) {
-	(*mautrix.RespError)(re).Write(w)
+func (re RespError) Write(w http.ResponseWriter) {
+	mautrix.RespError(re).Write(w)
 }
 
 func (re RespError) WithMessage(msg string, args ...any) RespError {

diff --git a/error.go b/error.go
@@ -143,12 +143,12 @@ func (e *RespError) MarshalJSON() ([]byte, error) {
 	return json.Marshal(data)
 }
 
-func (e *RespError) Write(w http.ResponseWriter) {
+func (e RespError) Write(w http.ResponseWriter) {
 	statusCode := e.StatusCode
 	if statusCode == 0 {
 		statusCode = http.StatusInternalServerError
 	}
-	exhttp.WriteJSONResponse(w, statusCode, e)
+	exhttp.WriteJSONResponse(w, statusCode, &e)
 }
 
 func (e RespError) WithMessage(msg string, args ...any) RespError {