Giphy GIF search integration #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulir
reviewed
May 12, 2024
…au.dev for MSC3860 redirects
hegdenischay
commented
May 12, 2024
hegdenischay
commented
May 12, 2024
tulir
reviewed
May 12, 2024
|
Oh, why was this closed @tulir? Edit: ah! it was merged! Sorry, I was confused. The merge icon was still red for some reason. Awesome :) |
|
I think it was because it wasn't merged directly, but by integrating my commits with another one of his. Also, it looks much better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #22. It brings a tab in the stickerpicker that can send GIFs.
Because the current implementation relies on MSC4039, it uses the
upload_filefunction given by matrix-widget-api, and also has to basically download and upload GIFs to the client before sending them asm.stickerevents. This also means that it is only supported by clients that have said function.This is how the GIF picker looks like:
A demo version is hosted here to try it out.