Calendar should be an entity, consolidate like impl

mattruggio · Jun 30, 2023 · 32e8372 · 32e8372
1 parent f9edeec
commit 32e8372
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/docs/architecture.png b/docs/architecture.png
diff --git a/lib/basketball/season/calendar.rb b/lib/basketball/season/calendar.rb
@@ -4,7 +4,7 @@ module Basketball
   module Season
     # Sets boundaries for exhibition and regular season play.  Add games as long as they are
     # within the correct dated boundaries
-    class Calendar
+    class Calendar < Entity
       class OutOfBoundsError < StandardError; end
       class TeamAlreadyBookedError < StandardError; end
 
@@ -21,6 +21,8 @@ def initialize(
         regular_end_date:,
         games: []
       )
+        super()
+
         raise ArgumentError, 'exhibition_start_date is required' if exhibition_start_date.to_s.empty?
         raise ArgumentError, 'exhibition_end_date is required'   if exhibition_end_date.to_s.empty?
         raise ArgumentError, 'regular_start_date is required'    if regular_start_date.to_s.empty?

diff --git a/lib/basketball/season/league.rb b/lib/basketball/season/league.rb
@@ -111,7 +111,7 @@ def teams
       end
 
       def players
-        conferences.flat_map(&:players) + free_agents
+        signed_players + free_agents
       end
 
       def conference_for(team)

diff --git a/lib/basketball/version.rb b/lib/basketball/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basketball
-  VERSION = '0.0.23'
+  VERSION = '0.0.24'
 end