Fix/usleep #568
Merged
Fix/usleep #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: Feature Table Add: Links Add: TOC Fix: References for TOC
* Keep current build tags backwards compliant * Added alias for `sqlite_json1` => `sqlite_json`
Fix: New build tag(s) names
Add documentation to feature table for tag `trace`
Usage of new build tag names
Added Cross-Compile jobs for additional feature(s)
Required for building SQLite module `icu`
Closes mattn#567
Removed: 32Bit Windows Cross-Compile Aggregated: sqlite_trace into main module build
[ci skip]
Implement `usleep` for Windows OS.
[ci skip]
|
Build successful; coverage failed probably because it was a decrease apparently because of the added file. Can be merged after #563 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite3.go defines the following:
Line: 12
This means
usleepis activated even for Windows OS.However usleep is a *nix command and not available on Windows.
When usleep is not available SQLite3 waits for 1 second.
This implementation adds the
usleepcommand for Windows to increases performance.Full fix review
BenchMark
BenchMark before fix.
BenchMark after fix.
This PR is based upon #563 please merge #563 before merging this.
@mattn Please remove you stale branch
add-usleep.