remove import failure

mattip · Jan 21, 2017 · 279fdf6 · 279fdf6
1 parent de44877
commit 279fdf6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/doc/source/whatsnew/v0.20.0.txt b/doc/source/whatsnew/v0.20.0.txt
@@ -384,6 +384,7 @@ Bug Fixes
 
 - Bug in ``pd.read_msgpack()`` in which ``Series`` categoricals were being improperly processed (:issue:`14901`)
 - Bug in ``Series.ffill()`` with mixed dtypes containing tz-aware datetimes. (:issue:`14956`)
+- Bug in ``.replace()`` may result in incorrect dtypes. (:issue:`12747`)
 
 
 

diff --git a/pandas/core/internals.py b/pandas/core/internals.py
@@ -3236,7 +3236,7 @@ def comp(s):
             return _possibly_compare(values, getattr(s, 'asm8', s),
                                      operator.eq)
 
-        def _cast(block, scalar):
+        def _cast_scalar(block, scalar):
             dtype, val = _infer_dtype_from_scalar(scalar, pandas_dtype=True)
             if not is_dtype_equal(block.dtype, dtype):
                 dtype = _find_common_type([block.dtype, dtype])
@@ -3268,7 +3268,7 @@ def _cast(block, scalar):
                         # particular block
                         m = masks[i][b.mgr_locs.indexer]
                         if m.any():
-                            b, val = _cast(b, d)
+                            b, val = _cast_scalar(b, d)
                             new_rb.extend(b.putmask(m, val, inplace=True))
                         else:
                             new_rb.append(b)

diff --git a/pandas/types/cast.py b/pandas/types/cast.py
@@ -19,7 +19,7 @@
                      _ensure_int8, _ensure_int16,
                      _ensure_int32, _ensure_int64,
                      _NS_DTYPE, _TD_DTYPE, _INT64_DTYPE,
-                     _DATELIKE_DTYPES, _POSSIBLY_CAST_DTYPES)
+                     _POSSIBLY_CAST_DTYPES)
 from .dtypes import ExtensionDtype, DatetimeTZDtype, PeriodDtype
 from .generic import ABCDatetimeIndex, ABCPeriodIndex, ABCSeries
 from .missing import isnull, notnull