Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failure, serde, structopt #26

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Conversation

sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Dec 5, 2019

Conservatively update dependencies so that we use syn and quote 1.0 and only single version of them.

This time I didn't forget to run cargo test!

@mattias-p
Copy link
Owner

What difference does this make? Smaller binary size?
Is there some property here that ought to be maintained over time? If so, do you know of a good way to detect regressions?

@sanxiyn
Copy link
Contributor Author

sanxiyn commented Dec 7, 2019

There should be no visible differences to users. These are procedural macros, so not smaller binary size.

I guess it does save compile time, since syn and quote are fairly large and now they are not compiled twice. cargo tree -d (for duplicate) can print dependencies with multiple versions.

@mattias-p
Copy link
Owner

Sorry for letting you wait :( My life got in the way.
Cargo tree is pretty neat! But what a mess it reveals.
Well, I see no harm in these changes.

@mattias-p mattias-p merged commit 839b959 into mattias-p:master Dec 14, 2019
@sanxiyn sanxiyn deleted the update branch December 18, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants