Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[PLT-7814] Upgrade to enzyme-adapter-react-16 and enable unit/components tests a… #310

Merged
merged 2 commits into from
Nov 18, 2017

Conversation

saturninoabril
Copy link
Member

Summary

This is the final batch for PLT-7814, resolving existing (and additional) component test failures.

This is resubmitted as branch. Original PR from #303.

Included in this PR:

  1. Add make test command
  2. Enable unit/components tests at Jenkins build.
  3. Add make test to PR checklist
  4. Add reducers and selectors folders for test coverage computation
  5. Add "clearMocks": true to jest config to automatically clear mock calls and instances between every test.

Ticket Link

Jira ticket: PLT-7814

(UPDATE): Jira ticket to revert component tests - PLT-8133

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Added or updated unit tests (required for all new features)
  • Touches critical sections of the codebase (Jenkins build, make file)

Copy link
Member

@crspeller crspeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@crspeller crspeller merged commit 73568ad into master Nov 18, 2017
@crspeller crspeller deleted the PLT-7814-17 branch November 18, 2017 00:20
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 20, 2017
@esethna esethna added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants