-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dynamodb tests permissions #98
Conversation
Hi @tremble, would you be able to review this ? I've drafted a new PR as requested to the new aws community collections repo, and I think this here PR is the missing piece to getting the tests to pass :) Also once merged, how will this be made available to the collections repo tests ? |
@marknet15 permissions look sane on my side. That covers making them available to devs you'll need to tweak a second file (aws/policy/data-services.yaml) to make them available to CI. For what it's worth, I agree it's annoying to update in two places with two formats. I have a PR in place to make this more consistent. CC: @jillr (who can actually merge this) |
@tremble awesome thanks, so I've had a look at https://github.com/mattclay/aws-terminator/blob/master/aws/policy/data-services.yaml and updated it to hold the permissions i added in the other file. That's nice to hear :) not a huge problem at any rate |
Just to set expectations: @jillr generally does the merges on this repo (although mattclay and s-hertel can too), and generally reviews the PR queue for this repo on Thursdays... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These permissions look sensible however I'm unable to test with the associated PR, left some comments there outlining the problems I've run into.
@marknet15 I saw your comment in the other PR about picking this back up, you'll also need to resolve the git conflicts in this PR please. |
Overview
I've raised this as requested (linked below) in order to move over a pull request from ansible to the new aws collections repo:
ansible-collections/community.aws#65
ansible/ansible#68320 (comment)