Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if check before using cursor #285

Merged
merged 1 commit into from
Jul 16, 2017

Conversation

didia
Copy link
Contributor

@didia didia commented Jul 16, 2017

Requirements

Filling out this template is required.

Description of the Change

Right now, if you set option fadeOut: true and showCursor: false we have an error because we are trying to add the fadeOutClass to the cursor.className while the cursor does not exist.

I have added if checks to check if the cursor exist before using it.

Benefits

No errors and the fadeout is usable without the cursor. Cheers 🎉

Issues

@didia didia force-pushed the fix/optional-cursor-classname branch 2 times, most recently from 8c6fa1d to ed34b4d Compare July 16, 2017 19:29
@didia didia force-pushed the fix/optional-cursor-classname branch from ed34b4d to e2e13e4 Compare July 16, 2017 19:32
@mattboldt mattboldt merged commit 35a4e24 into mattboldt:master Jul 16, 2017
@mattboldt
Copy link
Owner

Thank you very much! And I really appreciate you making demos and detailing all your changes.

@didia didia deleted the fix/optional-cursor-classname branch July 17, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants