Remove a good part of the sources of abusive typing #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
force-pushed
the
enforce-static-typing
branch
from
636f6cc
to
b22cda6
Compare
ppedrot
added a commit
to ppedrot/opam-coq-archive
that referenced
this pull request
Jun 2, 2024
ppedrot
added a commit
to ppedrot/coq
that referenced
this pull request
Jun 2, 2024
|
@mattam82 I'm merging this, CI is green an metacoq is compiling so it's probably safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We carefully infer the minimal amount of constraints instead of unconditionally typing stuff on sight. There are still a few instances of useless typing but they are more tricky. (The next one on my radar is Simplify.solution).
This PR has been tested on MetaCoq. I'll try to get a bench running on it when the Coq workers are under a reasonable load.