Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an empty ip_range_blacklist to allow connecting to localhost. #987

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Use an empty ip_range_blacklist to allow connecting to localhost. #987

merged 1 commit into from
Dec 9, 2020

Conversation

clokep
Copy link
Member

@clokep clokep commented Dec 9, 2020

Corresponds to matrix-org/synapse#8870. Empties out the new ip_range_blacklist setting (similar to federation_ip_range_blacklist) so that connections to private IPs work OK.

@clokep clokep requested a review from a team December 9, 2020 13:41
anoadragon453
anoadragon453 approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clokep clokep merged commit 729af31 into develop Dec 9, 2020
@clokep clokep deleted the clokep/ip-blacklist-defaults branch December 9, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clokep @anoadragon453