Correctly return the full auth chain in test #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Jul 10, 2020
| # not just y's auth_events. It doesn't matter too much | ||
| # here though. | ||
| map { $_->[0] } @{ $missing_event_y->{auth_events} }, | ||
| map { $_->{event_id} } @auth_chain, |
There was a problem hiding this comment.
ftr, this won't work in room v3 or later, though it looks like the whole test needs an update for that anyway. The right way to write this is $room->id_for_event( $_ ).
anoadragon453
added a commit
that referenced
this pull request
Aug 4, 2020
* origin/release-v1.18.0: Unbreak dendrite Test `/make_join` when applied to an empty room (#917) Add new database Unstable for cross signing Unstable for cross signing Use r0 not unstable for e2e keys and sendToDevice Correctly return the full auth chain in test (#911) Unflake "Outbound federation will ignore a missing event with bad JSON for room version 6" (#912) Test that the client sees a leave event after invite rejection (#909) Update device management tests to be spec-compliant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synapse now needs the auth chain to be correct: matrix-org/synapse#7817