Fix installing from a readonly copy of synapse #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that, as of pip 20.1, pip likes to do an in-tree build of synapse when you install it, which is pretty nasty when pip is running in a docker image. We can work around this by copying the bits we need into a tarball and installing from that. Ultimately I'd like to change the build pipelines to build a wheel upfront, and use that for the sytest builds, which will be a more accurate representation of how most people install synapse, but this is a prerequisite.
|
(worth noting that this only becomes a problem if/when we rebuild the sytest-synapse docker images) |
clokep
reviewed
May 11, 2020
scripts/synapse_sytest.sh
Outdated
Comment on lines
29
to
32
| #su -c psql postgres <<< "show config_file" | ||
| #su -c psql postgres <<< "show max_connections" | ||
| #su -c psql postgres <<< "show full_page_writes" | ||
| #su -c psql postgres <<< "show fsync" |
There was a problem hiding this comment.
Should we remove these if they're not useful?
clokep
reviewed
May 11, 2020
clokep
reviewed
May 11, 2020
| @@ -110,6 +110,24 @@ elif [ -n "$POSTGRES" ]; then | |||
|
|
|||
| fi | |||
|
|
|||
| # default value for SYNAPSE_SOURCE | |||
| : ${SYNAPSE_SOURCE:=/src} | |||
There was a problem hiding this comment.
Neat, did not know this about bash. (https://wiki.bash-hackers.org/syntax/pe#assign_a_default_value if anyone else doesn't know what this does)
clokep
approved these changes
May 11, 2020
pull bot
pushed a commit
to valkum/sytest
that referenced
this pull request
May 14, 2020
It seems that, as of pip 20.1, pip likes to do an in-tree build of synapse when you install it, which is pretty nasty when pip is running in a docker image. We can work around this by copying the bits we need into a tarball and installing from that. Ultimately I'd like to change the build pipelines to build a wheel upfront, and use that for the sytest builds, which will be a more accurate representation of how most people install synapse, but this is a prerequisite.
anoadragon453
added a commit
that referenced
this pull request
Jun 10, 2020
* release-v1.14.0: Add API environment variable for Dendrite monolith (#877) Use /sync not /events Use /sync not /events Use /sync not /events for test 'Outbound federation can request missing events' Review comments Fix race in 'Outbound federation can backfill events' Deflake guest user test (#871) Pass through DENDRITE_TRACE_ env vars to the dendrite binary Fix installing from a readonly copy of synapse (#866) Remove race condition in dendrite Remove debug More /sync less /events Use /sync not /events to fetch data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that, as of pip 20.1, pip likes to do an in-tree build of synapse when
you install it, which is pretty nasty when pip is running in a docker image.
We can work around this by copying the bits we need into a tarball and
installing from that. Ultimately I'd like to change the build pipelines to
build a wheel upfront, and use that for the sytest builds, which will be a more
accurate representation of how most people install synapse, but this is a
prerequisite.
See also: https://discuss.python.org/t/installing-from-a-read-only-source/4115/3