Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Run mypy as part of the lint script #8633

Merged
merged 7 commits into from
Oct 28, 2020
Merged

Run mypy as part of the lint script #8633

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f174320
Add instructions to run mypy in a venv.
kleph Oct 22, 2020
212512a
Fix typo
kleph Oct 22, 2020
b46df32
Correct PR's final name in changelog
kleph Oct 22, 2020
c168f20
Add mypy to the general lint.sh script and update doc
kleph Oct 27, 2020
a45dbb5
Remove unnecessary argument
kleph Oct 27, 2020
861804f
Rephrase instructions and remove redundant section since it's part of
kleph Oct 27, 2020
ae6e439
Add a period at the end of the changelog.
clokep Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ locally. You'll need python 3.6 or later, and to install a number of tools:

```
# Install the dependencies
pip install -e ".[lint]"
pip install -e ".[lint,mypy]"

# Run the linter script
./scripts-dev/lint.sh
Expand All @@ -63,7 +63,7 @@ run-time:
./scripts-dev/lint.sh path/to/file1.py path/to/file2.py path/to/folder
```

You can also provided the `-d` option, which will lint the files that have been
You can also provide the `-d` option, which will lint the files that have been
changed since the last git commit. This will often be significantly faster than
linting the whole codebase.

Expand Down
1 change: 1 addition & 0 deletions changelog.d/8633.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Run `mypy` as part of the lint.sh script
clokep marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions scripts-dev/lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,4 @@ isort "${files[@]}"
python3 -m black "${files[@]}"
./scripts-dev/config-lint.sh
flake8 "${files[@]}"
mypy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I think running this over $files[@] doesn't make sense until we support mypy in all of our files.