Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Do not install setuptools 50.0 on Python 3.5 #8212

Merged
merged 6 commits into from
Sep 1, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion INSTALL.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ mkdir -p ~/synapse
virtualenv -p python3 ~/synapse/env
source ~/synapse/env/bin/activate
pip install --upgrade pip
pip install --upgrade setuptools
pip install --upgrade setuptools!=50.0 # setuptools==50.0 fails on some older Python versions
pip install matrix-synapse
```

Expand Down
1 change: 1 addition & 0 deletions changelog.d/8212.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not install setuptools 50.0 on Python 3.5, which leads to a broken configuration.
clokep marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 4 additions & 0 deletions synapse/python_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@
"Jinja2>=2.9",
"bleach>=1.4.3",
"typing-extensions>=3.7.4",
# setuptools is required by a variety of dependencies, unfortunately version
# 50.0 is incompatible with older Python versions, see
# https://github.com/pypa/setuptools/issues/2352
'setuptools!=50.0',
]

CONDITIONAL_REQUIREMENTS = {
Expand Down