Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Downgrade warning on client disconnect to INFO #7928

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Downgrade warning on client disconnect to INFO #7928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c815cf
Downgrade warning on client disconnect.
richvdh Jul 21, 2020
70889f7
remove excessively specific test
richvdh Jul 23, 2020
4bf1c3c
fix lint
richvdh Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/7928.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When a client disconnects, don't log it as 'Error processing request'.
4 changes: 1 addition & 3 deletions synapse/http/site.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,7 @@ def connectionLost(self, reason):
# It's useful to log it here so that we can get an idea of when
# the client disconnects.
with PreserveLoggingContext(self.logcontext):
logger.warning(
"Error processing request %r: %s %s", self, reason.type, reason.value
)
logger.info("Connection from client lost before response was sent")

if not self._is_processing:
self._finished_processing()
Expand Down