This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Correctly pass app_name to all email templates. #7829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't do this for e.g. registration emails.
clokep
reviewed
Jul 13, 2020
clokep
approved these changes
Jul 13, 2020
| @@ -0,0 +1 @@ | |||
| Fix bug where we did not always pass in `app_name` or `server_name` to email templates, including e.g. for registration emails. | |||
There was a problem hiding this comment.
Has this "always" been this way or was it broken at some point? (Do we need to add a "broken since v..."?)
There was a problem hiding this comment.
I think this has always been broken for these emails, as they were added later at different times
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'f886a6991': Correctly pass app_name to all email templates. (#7829)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't do this for e.g. registration emails.