Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix recursion error when fetching auth chain over federation #7817

Merged
merged 9 commits into from
Jul 10, 2020
Merged

Fix recursion error when fetching auth chain over federation #7817

merged 9 commits into from
Jul 10, 2020

Commits on Jul 10, 2020

  1. Fix recursion error when fetching auth chain 

    When fetching the state of a room over federation we receive the event
IDs of the state and auth chain. We then fetch those events that we
don't already have.

However, we used a function that recursively fetched any missing auth
events for the fetched events, which can lead to a lot of recursion if
the server is missing most of the auth chain. This work is entirely
pointless because would have queued up the missing events in the auth
chain to be fetched already.

Let's just diable the recursion, since it only gets called from one
place anyway.
    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    e963a55 View commit details
    Browse the repository at this point in the history

  2. Newsfile

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    2b3916d View commit details
    Browse the repository at this point in the history

  3. Review comments

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    cad85d5 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7825a59 View commit details
    Browse the repository at this point in the history

  5. get_events requires a list...

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    c6df9ac View commit details
    Browse the repository at this point in the history

  6. Make exception autherror in check auth

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f6856d8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' of github.com:matrix-org/synapse into erikj/fi… 

    …x_recursion_error
    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    f7488b9 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @erikjohnston @richvdh
    erikjohnston and richvdh committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    212f9e7 View commit details
    Browse the repository at this point in the history

  9. Use 403 and update comment

    @erikjohnston
    erikjohnston committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    e0c9f59 View commit details
    Browse the repository at this point in the history