Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Re-implement unread counts #7736

Merged
merged 47 commits into from
Jul 29, 2020
Merged

Re-implement unread counts #7736

merged 47 commits into from
Jul 29, 2020

Commits on Jun 30, 2020

  1. Store unread messages in the database

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    80d03b1 View commit details
    Browse the repository at this point in the history

  2. Count the number of unread messages on sync requests

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9db0bac View commit details
    Browse the repository at this point in the history

  3. Handle redactions

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    e33b891 View commit details
    Browse the repository at this point in the history

  4. Only insert rows for local users 

    Also run the linters
    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    0ee1963 View commit details
    Browse the repository at this point in the history

  5. Handle lack of read receipt in a room

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9cb9378 View commit details
    Browse the repository at this point in the history

  6. Don't mark an event as unread for its own sender

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    9e723dd View commit details
    Browse the repository at this point in the history

  7. Run linter

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    5399a7b View commit details
    Browse the repository at this point in the history

  8. Fetch joined users from current_state_events instead of room_memberships

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    580b499 View commit details
    Browse the repository at this point in the history

  9. Send unread count to the push gateway

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    ff8b39d View commit details
    Browse the repository at this point in the history

  10. Add a redaction helper for tests

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    eafdf9f View commit details
    Browse the repository at this point in the history

  11. Add test case for unread counts

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    994f267 View commit details
    Browse the repository at this point in the history

  12. Run linter on tests

    @babolivier
    babolivier committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    00fd951 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2020

  1. Implement the latest changes in the MSC

    @babolivier
    babolivier committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    a008f6f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into babolivier/unread_counts

    @babolivier
    babolivier committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    fe5352f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. Incorporate most review comments

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    d980c86 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'babolivier/unread_counts' of github.com:matrix-org/syna… 

    …pse into babolivier/unread_counts
    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    3d3e048 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into babolivier/unread_counts

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    572753b View commit details
    Browse the repository at this point in the history

  4. Lint

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    bf1b1ec View commit details
    Browse the repository at this point in the history

  5. Lint

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e07fef1 View commit details
    Browse the repository at this point in the history

  6. Fix column type

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    8b9d073 View commit details
    Browse the repository at this point in the history

  7. Fix default value

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    287c263 View commit details
    Browse the repository at this point in the history

  8. Update port_db's list of bool columns

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    b5972a9 View commit details
    Browse the repository at this point in the history

  9. Add a cache to get_unread_message_count_for_user

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    e9e2d88 View commit details
    Browse the repository at this point in the history

  10. Fix function call and cache invalidation

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    bc44ad4 View commit details
    Browse the repository at this point in the history

  11. Lint

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    9b9f6e2 View commit details
    Browse the repository at this point in the history

  12. Invalidate the cache in the main thread

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    881fed3 View commit details
    Browse the repository at this point in the history

  13. Fix push badge computation

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    52ddc4d View commit details
    Browse the repository at this point in the history

  14. Lint

    @babolivier
    babolivier committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    ea01eff View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Use invalidate_cache_and_stream to invalidate the cache across workers

    @babolivier
    babolivier committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    aa0a56b View commit details
    Browse the repository at this point in the history

  2. Process the cache stream first for incoming replication 

    Receiving new data about e.g. events, read receipts, etc., is likely to
result in some database actions. An example of that is that we send a
push on new read receipts, which involves calculating a badge from
unread counts. Because of this, we probably want to process cache
updates/invalidations first so these actions are not using outdated
cache data. In the previous example, we want to make sure we invalidate
the cache on calculating the unread count for the user/room the read
receipt is for before sending a push.
    @babolivier
    babolivier committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    420573a View commit details
    Browse the repository at this point in the history

  3. Fix receipts replication test

    @babolivier
    babolivier committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    79464f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Merge branch 'develop' into babolivier/unread_counts

    @babolivier
    babolivier committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    48a2a00 View commit details
    Browse the repository at this point in the history

  2. Revert "Fix receipts replication test" 

    This reverts commit 79464f8.
    @babolivier
    babolivier committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0710078 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2020

  1. Revert "Process the cache stream first for incoming replication" 

    This reverts commit 420573a.
    @babolivier
    babolivier committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    ea10fc1 View commit details
    Browse the repository at this point in the history

  2. Revert "Use invalidate_cache_and_stream to invalidate the cache acros… 

    …s workers"

This reverts commit aa0a56b.
    @babolivier
    babolivier committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    0ea0792 View commit details
    Browse the repository at this point in the history

  3. Fix read receipt cache invalidation (hopefully)

    @babolivier
    babolivier committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    096aca9 View commit details
    Browse the repository at this point in the history

  4. Lint

    @babolivier
    babolivier committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    28f3e2b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2020

  1. Merge branch 'develop' of github.com:matrix-org/synapse into babolivi… 

    …er/unread_counts
    @babolivier
    babolivier committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    2302b6c View commit details
    Browse the repository at this point in the history

  2. Incorporate review

    @babolivier
    babolivier committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    d40557b View commit details
    Browse the repository at this point in the history

  3. Fix unread messages test

    @babolivier
    babolivier committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    5d3aaf7 View commit details
    Browse the repository at this point in the history

  4. Lint

    @babolivier
    babolivier committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    6f50007 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' of github.com:matrix-org/synapse into babolivi… 

    …er/unread_counts
    @babolivier
    babolivier committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    b265bef View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Remove default value for count_as_unread 

    So we don't end up rewriting the whole events table when running postgres < 11.
    @babolivier
    babolivier committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    debedb3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' of github.com:matrix-org/synapse into babolivi… 

    …er/unread_counts
    @babolivier
    babolivier committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    57ded3e View commit details
    Browse the repository at this point in the history

  3. Match the latest changes on the MSC

    @babolivier
    babolivier committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    82d9f39 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @babolivier
    babolivier committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    17e922a View commit details
    Browse the repository at this point in the history

  5. Typo

    @babolivier
    babolivier committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    d7fdc35 View commit details
    Browse the repository at this point in the history