This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Unflake "Guest user can set display names" #7327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Apr 22, 2020
There was a problem hiding this comment.
For reasons which I hope matrix-org/sytest#836 (comment) might explain, I think this is probably fixing the problem in the wrong place, and doing it this way will mean that there are other ways this bug can bite which won't get fixed.
It's certainly an interesting and valuable datapoint if this deflakes the test, though.
…nflake_guest_user_test
…lake_guest_user_test
|
Superseded by matrix-org/sytest#871 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my investigation, I found that setting the max cache entries for
get_latest_event_ids_in_roomto 0 unflaked this test, meaning that there was somewhere we weren't invalidating this cache when we should've been.I couldn't find anywhere where we did so after a membership change, so I've added the appropriate line. I'd appreciate feedback on this as I don't have a complete understanding of the replication code.