Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Change displayname of user as admin in rooms #6876

Merged
merged 10 commits into from
Feb 21, 2020
Merged

Change displayname of user as admin in rooms #6876

merged 10 commits into from
Feb 21, 2020

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Feb 7, 2020

Try to fix #6572

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a [changelog file]
  • Pull request includes a sign off
  • Code style is correct (run the linters)

Signed-off-by: Dirk Klimpel dirk@klimpel.org

@richvdh richvdh requested a review from a team February 9, 2020 16:34
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! a few nits though:

synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/profile.py Outdated Show resolved Hide resolved
synapse/handlers/profile.py Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
Change displayname of users as admin in rooms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some more words here? remember that the changelog is supposed to explain to Synapse admins what has changed: this really doesn't. Also feel free to add an attribution to yourself.

Something like this?

When a user's profile is updated via the admin API, also generate a displayname/avatar update for that user in each room. Contributed by @dklimpel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion and review.

@richvdh richvdh self-assigned this Feb 13, 2020
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@richvdh richvdh merged commit 7b0e2d9 into matrix-org:develop Feb 21, 2020
@dklimpel dklimpel deleted the rename_displayname branch February 21, 2020 17:56
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Apr 15, 2020
babolivier pushed a commit that referenced this pull request Sep 1, 2021
* commit '7b0e2d961':
  Change displayname of user as admin in rooms (#6876)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants