-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Change displayname of user as admin in rooms #6876
Conversation
Resync Develop
Resync develop branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! a few nits though:
changelog.d/6572.bugfix
Outdated
@@ -0,0 +1 @@ | |||
Change displayname of users as admin in rooms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some more words here? remember that the changelog is supposed to explain to Synapse admins what has changed: this really doesn't. Also feel free to add an attribution to yourself.
Something like this?
When a user's profile is updated via the admin API, also generate a displayname/avatar update for that user in each room. Contributed by @dklimpel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion and review.
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Resync develop branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks!
* commit '7b0e2d961': Change displayname of user as admin in rooms (#6876)
Try to fix #6572
Pull Request Checklist
Signed-off-by: Dirk Klimpel dirk@klimpel.org