This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Pass through room version to event auth #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4482 +/- ##
===========================================
+ Coverage 74.71% 74.74% +0.02%
===========================================
Files 336 336
Lines 34102 34152 +50
Branches 5544 5554 +10
===========================================
+ Hits 25481 25527 +46
Misses 7048 7048
- Partials 1573 1577 +4 |
richvdh
approved these changes
Jan 28, 2019
synapse/handlers/message.py
Outdated
| @@ -611,8 +611,13 @@ def handle_new_client_event( | |||
| extra_users (list(UserID)): Any extra users to notify about event | |||
| """ | |||
|
|
|||
| if event.is_state() and (event.type, event.state_key) == (EventTypes.Create, ""): | |||
| room_version = event.content["room_version"] | |||
There was a problem hiding this comment.
I reckon you can get here without there being a room_version, if you hit PUT /rooms/<room_id>/state/m.room.create. Obviously that's a silly thing to do, but blowing up with an exception doesn't seem like the right thing to do.
There was a problem hiding this comment.
Fair, though I'd be surprised if we actually let people send a create event if they're not in the room.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.