Push complement image to a docker registry #14509

michaelkaye · 2022-11-21T17:16:10Z

This PR automates the building of complement images for key branches (main/master, develop). A few projects eg matrix-org/trafficlight & matrix-appservice-irc are using homerunner from complement to manage setup and teardown of synapse and dendrite servers within tests.

We're noticing that we're asking github actions or developers to locally create these images each time we run our tests - but actually that's not relevant for using homerunner to start integration tests of clients etc. Having a registry would let us avoid running out of date synapse servers and hopefully speed up test times on GHA.

I chose (for now at least) to keep this workflow separate from the docker.yaml - We login to a different repository and probably don't want to share secrets with this build process (the complement image has a specific script to build). Should we combine these workflows?, or we could even incorporate the build process directly into the GHA - which might enable us to keep the same labels as are used on the main synapse image.

I chose not to publish the workers docker image as it's an intermediate one that doesn't seem to have much use outside of locally built developer machines. Should we publish this?.

I chose to push to ghcr.io rather than docker-hub to reduce the visibility of the created image - we don't want people using these images for anything other than testing using complement; and this is in many ways just a cache of the build. Before we merge the PR, we should probably consider changing the location or naming of these images

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Pull request includes a sign off
Code style is correct
(run the linters)

michaelkaye · 2022-11-21T17:17:13Z

https://github.com/michaelkaye/synapse/actions/runs/3516474915 is the build running on my fork of synapse.

michaelkaye · 2022-11-21T17:18:18Z

cc @Half-Shot for possible interest

Remove special casing for michaelk branch.

.github/workflows/complement.yml

Should run on master, develop not main, develop

reivilibre

LGTM otherwise

.github/workflows/complement.yml

reivilibre · 2022-11-24T09:16:05Z

.github/workflows/complement.yml

+on:
+  push:
+    branches: ["master", "develop"]


this is basically entirely up to you, but do you want to push images for tagged releases?
I could see it maybe being useful for comparing different releases if necessary.

At least for bridges, we've only got the CI bandwidth for doing so many tests, so we're just doing master (and soon develop) for the moment. The idea is to test against latest stable, and also ensuring any new changes landing in Synapse don't break stuff (or vice versa).

Release testing would be nice if we had named supported versions of synapse though.

For my test cases, we probably only want to test current and next as well; if people want to investigate certain synapse versions then that can happen as a local build for now.

(Adding more options can come as required.)

…ye/synapse into michaelk/push_complement_image

michaelkaye · 2022-11-24T15:31:19Z

It looks like this is OK from a technical standpoint - would like to confirm that my questions in bold have been considered before we merge and start making these artifacts public.

DMRobertson · 2022-11-24T16:28:05Z

.github/workflows/push_complement_image.yml

+name: Store complement synapse image in ghcr.io
+on:
+  push:
+    branches: ["master", "develop"]


Can you add per-branch concurrency limits here, to limit GHA worker usage when merge a bunch of PRs in short order? See e.g. https://github.com/matrix-org/sytest/blob/bebf431edf7311d5147139f44dab97131a784d29/.github/workflows/pipeline.yml#L7-L12 from sytest

DMRobertson

Discussed during triage meeting. @erikjohnston mentioned that doing this for every develop build might eat up into our pool of github actions workers. We might consider only running this nightly for develop in the future, but this is probably fine for now.

Should we combine these workflows?

Let's keep them separate.

Should we publish [the workers docker image]?

I think no (for now). The with-workers docker image is fairly new (and was only created recently, to test Synapse with workers under complement). I think it sees some use by the community but not a whole lot.

More generally: I think it's the Synapse team's job to make sure that Synapse-polylith behaves like Synapse-polylith; I don't think it's on downstream testers to cover that use case.

Before we merge the PR, we should probably consider changing the location or naming of these images

complement-synapse is probably fine (though the name "complement" doesn't obviously mean "test purposes only do not use in production"). As long as we're not advertising the existence of this image, I think it's fine.

michaelkaye · 2022-11-25T17:00:40Z

I've made the appropriate changes (i believe) to run the build at 5am on develop and on push to master, as well as cancelling builds that are in flight. Testing this is always a bit weird so would benefit from someone with write access to repo doing the merge and watching it.

DMRobertson

I'll fixup the crontab; otherwise LGTM. Let's get it merged and try it out.

(I might have to ask you to check back tomorrow to see if this build and pushed a sensible image overnight)

.github/workflows/push_complement_image.yml

DMRobertson · 2022-11-28T12:24:27Z

Hmm. Why is https://github.com/matrix-org/synapse/actions/runs/3564702663 unhappy?

.github/workflows/push_complement_image.yml

Ctrl-Alt-L in PyCharm

DMRobertson · 2022-11-28T12:51:28Z

Hmm. Why is matrix-org/synapse/actions/runs/3564702663 unhappy?

Guessing it didn't like the yaml syntax. I've tried to fix this up. I've also stuck in something to try and let us run this once it's merged.

DMRobertson · 2022-11-28T12:57:46Z

The workflow is not valid. .github/workflows/push_complement_image.yml (Line: 37, Col: 13): Unexpected symbol: '"workflow_dispatch"'. Located at position 22 within expression: github.event.type == "workflow_dispatch" .github/workflows/push_complement_image.yml (Line: 42, Col: 13): Unexpected symbol: '"schedule"'. Located at position 22 within expression: github.event.type == "schedule"

I hate GHA sometimes. Maybe we should use https://github.com/rhysd/actionlint in the future.

DMRobertson · 2022-11-28T12:59:37Z

.github/workflows/push_complement_image.yml

+      - name: Tag and push generated image
+        run: |
+          for TAG in ${{ steps.meta.outputs.tags }}; do 
+            docker tag complement-synapse:latest $TAG


I wonder if master should point to latest and develop should have a different tag?

michaelkaye · 2022-11-28T15:03:29Z

The workflow is not valid. .github/workflows/push_complement_image.yml (Line: 37, Col: 13): Unexpected symbol: '"workflow_dispatch"'. Located at position 22 within expression: github.event.type == "workflow_dispatch" .github/workflows/push_complement_image.yml (Line: 42, Col: 13): Unexpected symbol: '"schedule"'. Located at position 22 within expression: github.event.type == "schedule"

I hate GHA sometimes. Maybe we should use https://github.com/rhysd/actionlint in the future.

Oh wow, this is what i've wanted in my life for so long.

* GHA workflow to build complement images of key branches. * Add changelog.d * GHA workflow to build complement images of key branches. * Add changelog.d * Update complement.yml Remove special casing for michaelk branch. * Update complement.yml Should run on master, develop not main, develop * Rename file to be more obvious * Merge did not go correctly. * Setup 5am builds of develop, limit to one run at once. * Fix crontab---run once at 5AM, not very minute between 5 and 6 * Fix cron syntax again? * Tweak workflow name * Allow manual debug runs * Tweak indentation Ctrl-Alt-L in PyCharm Co-authored-by: David Robertson <david.m.robertson1@gmail.com> Co-authored-by: David Robertson <davidr@element.io>

@ashfame

Synapse 1.73.0 (2022-12-06) =========================== Please note that legacy Prometheus metric names have been removed in this release; see [the upgrade notes](https://github.com/matrix-org/synapse/blob/release-v1.73/docs/upgrade.md#legacy-prometheus-metric-names-have-now-been-removed) for more details. No significant changes since 1.73.0rc2. Synapse 1.73.0rc2 (2022-12-01) ============================== Bugfixes -------- - Fix a regression in Synapse 1.73.0rc1 where Synapse's main process would stop responding to HTTP requests when a user with a large number of devices logs in. ([\matrix-org#14582](matrix-org#14582)) Synapse 1.73.0rc1 (2022-11-29) ============================== Features -------- - Speed-up `/messages` with `filter_events_for_client` optimizations. ([\matrix-org#14527](matrix-org#14527)) - Improve DB performance by reducing amount of data that gets read in `device_lists_changes_in_room`. ([\matrix-org#14534](matrix-org#14534)) - Adds support for handling avatar in SSO OIDC login. Contributed by @ashfame. ([\matrix-org#13917](matrix-org#13917)) - Move MSC3030 `/timestamp_to_event` endpoints to stable `v1` location (`/_matrix/client/v1/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>`, `/_matrix/federation/v1/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>`). ([\matrix-org#14471](matrix-org#14471)) - Reduce database load of [Client-Server endpoints](https://spec.matrix.org/v1.5/client-server-api/#aggregations) which return bundled aggregations. ([\matrix-org#14491](matrix-org#14491), [\matrix-org#14508](matrix-org#14508), [\matrix-org#14510](matrix-org#14510)) - Add unstable support for an Extensible Events room version (`org.matrix.msc1767.10`) via [MSC1767](matrix-org/matrix-spec-proposals#1767), [MSC3931](matrix-org/matrix-spec-proposals#3931), [MSC3932](matrix-org/matrix-spec-proposals#3932), and [MSC3933](matrix-org/matrix-spec-proposals#3933). ([\matrix-org#14520](matrix-org#14520), [\matrix-org#14521](matrix-org#14521), [\matrix-org#14524](matrix-org#14524)) - Prune user's old devices on login if they have too many. ([\matrix-org#14038](matrix-org#14038), [\matrix-org#14580](matrix-org#14580)) Bugfixes -------- - Fix a long-standing bug where paginating from the start of a room did not work. Contributed by @gnunicorn. ([\matrix-org#14149](matrix-org#14149)) - Fix a bug introduced in Synapse 1.58.0 where a user with presence state `org.matrix.msc3026.busy` would mistakenly be set to `online` when calling `/sync` or `/events` on a worker process. ([\matrix-org#14393](matrix-org#14393)) - Fix a bug introduced in Synapse 1.70.0 where a receipt's thread ID was not sent over federation. ([\matrix-org#14466](matrix-org#14466)) - Fix a long-standing bug where the [List media admin API](https://matrix-org.github.io/synapse/latest/admin_api/media_admin_api.html#list-all-media-in-a-room) would fail when processing an image with broken thumbnail information. ([\matrix-org#14537](matrix-org#14537)) - Fix a bug introduced in Synapse 1.67.0 where two logging context warnings would be logged on startup. ([\matrix-org#14574](matrix-org#14574)) - In application service transactions that include the experimental `org.matrix.msc3202.device_one_time_key_counts` key, include a duplicate key of `org.matrix.msc3202.device_one_time_keys_count` to match the name proposed by [MSC3202](matrix-org/matrix-spec-proposals#3202). ([\matrix-org#14565](matrix-org#14565)) - Fix a bug introduced in Synapse 0.9 where Synapse would fail to fetch server keys whose IDs contain a forward slash. ([\matrix-org#14490](matrix-org#14490)) Improved Documentation ---------------------- - Fixed link to 'Synapse administration endpoints'. ([\matrix-org#14499](matrix-org#14499)) Deprecations and Removals ------------------------- - Remove legacy Prometheus metrics names. They were deprecated in Synapse v1.69.0 and disabled by default in Synapse v1.71.0. ([\matrix-org#14538](matrix-org#14538)) Internal Changes ---------------- - Improve type hinting throughout Synapse. ([\matrix-org#14055](matrix-org#14055), [\matrix-org#14412](matrix-org#14412), [\matrix-org#14529](matrix-org#14529), [\matrix-org#14452](matrix-org#14452)). - Remove old stream ID tracking code. Contributed by Nick @beeper (@Fizzadar). ([\matrix-org#14376](matrix-org#14376), [\matrix-org#14468](matrix-org#14468)) - Remove the `worker_main_http_uri` configuration setting. This is now handled via internal replication. ([\matrix-org#14400](matrix-org#14400), [\matrix-org#14476](matrix-org#14476)) - Refactor `federation_sender` and `pusher` configuration loading. ([\matrix-org#14496](matrix-org#14496)) ([\matrix-org#14509](matrix-org#14509), [\matrix-org#14573](matrix-org#14573)) - Faster joins: do not wait for full state when creating events to send. ([\matrix-org#14403](matrix-org#14403)) - Faster joins: filter out non local events when a room doesn't have its full state. ([\matrix-org#14404](matrix-org#14404)) - Faster joins: send events to initial list of servers if we don't have the full state yet. ([\matrix-org#14408](matrix-org#14408)) - Faster joins: use servers list approximation received during `send_join` (potentially updated with received membership events) in `assert_host_in_room`. ([\matrix-org#14515](matrix-org#14515)) - Fix type logic in TCP replication code that prevented correctly ignoring blank commands. ([\matrix-org#14449](matrix-org#14449)) - Remove option to skip locking of tables when performing emulated upserts, to avoid a class of bugs in future. ([\matrix-org#14469](matrix-org#14469)) - `scripts-dev/federation_client`: Fix routing on servers with `.well-known` files. ([\matrix-org#14479](matrix-org#14479)) - Reduce default third party invite rate limit to 216 invites per day. ([\matrix-org#14487](matrix-org#14487)) - Refactor conversion of device list changes in room to outbound pokes to track unconverted rows using a `(stream ID, room ID)` position instead of updating the `converted_to_destinations` flag on every row. ([\matrix-org#14516](matrix-org#14516)) - Add more prompts to the bug report form. ([\matrix-org#14522](matrix-org#14522)) - Extend editorconfig rules on indent and line length to `.pyi` files. ([\matrix-org#14526](matrix-org#14526)) - Run Rust CI when `Cargo.lock` changes. This is particularly useful for dependabot updates. ([\matrix-org#14571](matrix-org#14571)) - Fix a possible variable shadow in `create_new_client_event`. ([\matrix-org#14575](matrix-org#14575)) - Bump various dependencies in the `poetry.lock` file and in CI scripts. ([\matrix-org#14557](matrix-org#14557), [\matrix-org#14559](matrix-org#14559), [\matrix-org#14560](matrix-org#14560), [\matrix-org#14500](matrix-org#14500), [\matrix-org#14501](matrix-org#14501), [\matrix-org#14502](matrix-org#14502), [\matrix-org#14503](matrix-org#14503), [\matrix-org#14504](matrix-org#14504), [\matrix-org#14505](matrix-org#14505)). # -----BEGIN PGP SIGNATURE----- # # iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmOPLnYACgkQLS76LzL7 # 4Edwpg/+KXpg2ZdiJ0Yaly9VHVeiqdHRi5D7WPS6n8YBsdRx9EQHzOBkD5HAW8hE # oz0c+zDS01ORlEWD825NYXjgaE1ijtZFvGxsftYTVuTYlVRR2m+r9jhDv9pVHT53 # TKtQVKpG0IUsuyukRBrweDcEeO0MA0nGpvaaQUhmftzWgy4yD3AjZyIgx0Ckg8pg # OwgrzGqA7FQs4MEeOxmk1H39fZg4dlo4nmI4whvAodgaGeS9sU8t+3Qj4PVod8v/ # AkVesJcruaTHuVMb+Xp8JKezb09SsIR94gmHalC5sL+41+6XAy9BtQ/cRDfCReG3 # U1I1x1h1+EQjTP6XzMmjQHLbfI2gUJBC4I2p3e2gZ4cMm9rVz94R1dBiRk8ZgRIC # cJFD9BvaAtb2PSTvyFBoHsrrn/u12i8fYFWu4Z4rO6dOGI83dZHeZzVw4UsVeqIK # 5+njQwcwQsrwL3AKLjbbdqmbmhXcF6LchIK2L+NuuvdiOfvXvkO0bdjBryVEbMqB # IOtAAWzwYaoUwVucMbBtXt/EqQS7biGkbDxsL8CDvaBwM/JSsUWXBafsV1FmxF2A # q6KAeKpfelefoegosTYD0Md+l39xdF8Z19XaKV3GeHZEY+HE3RJXJm+Pa8SJ+IF8 # Y1od9cB/H+fYSsWCWj1OJNqTIAozh6f1Pe2nFuFDxdBwABXc/pg= # =IBEL # -----END PGP SIGNATURE----- # gpg: Signature made Tue Dec 6 11:58:46 2022 GMT # gpg: using RSA key F124520CEEE062448FE1C8442D2EFA2F32FBE047 # gpg: Can't check signature: No public key # Conflicts: # poetry.lock # synapse/push/bulk_push_rule_evaluator.py # synapse/storage/databases/main/account_data.py # synapse/storage/databases/main/receipts.py

@ashfame

Synapse 1.73.0 (2022-12-06) =========================== Please note that legacy Prometheus metric names have been removed in this release; see [the upgrade notes](https://github.com/matrix-org/synapse/blob/release-v1.73/docs/upgrade.md#legacy-prometheus-metric-names-have-now-been-removed) for more details. No significant changes since 1.73.0rc2. Synapse 1.73.0rc2 (2022-12-01) ============================== Bugfixes -------- - Fix a regression in Synapse 1.73.0rc1 where Synapse's main process would stop responding to HTTP requests when a user with a large number of devices logs in. ([\#14582](matrix-org/synapse#14582)) Synapse 1.73.0rc1 (2022-11-29) ============================== Features -------- - Speed-up `/messages` with `filter_events_for_client` optimizations. ([\#14527](matrix-org/synapse#14527)) - Improve DB performance by reducing amount of data that gets read in `device_lists_changes_in_room`. ([\#14534](matrix-org/synapse#14534)) - Adds support for handling avatar in SSO OIDC login. Contributed by @ashfame. ([\#13917](matrix-org/synapse#13917)) - Move MSC3030 `/timestamp_to_event` endpoints to stable `v1` location (`/_matrix/client/v1/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction>`, `/_matrix/federation/v1/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction>`). ([\#14471](matrix-org/synapse#14471)) - Reduce database load of [Client-Server endpoints](https://spec.matrix.org/v1.5/client-server-api/#aggregations) which return bundled aggregations. ([\#14491](matrix-org/synapse#14491), [\#14508](matrix-org/synapse#14508), [\#14510](matrix-org/synapse#14510)) - Add unstable support for an Extensible Events room version (`org.matrix.msc1767.10`) via [MSC1767](matrix-org/matrix-spec-proposals#1767), [MSC3931](matrix-org/matrix-spec-proposals#3931), [MSC3932](matrix-org/matrix-spec-proposals#3932), and [MSC3933](matrix-org/matrix-spec-proposals#3933). ([\#14520](matrix-org/synapse#14520), [\#14521](matrix-org/synapse#14521), [\#14524](matrix-org/synapse#14524)) - Prune user's old devices on login if they have too many. ([\#14038](matrix-org/synapse#14038), [\#14580](matrix-org/synapse#14580)) Bugfixes -------- - Fix a long-standing bug where paginating from the start of a room did not work. Contributed by @gnunicorn. ([\#14149](matrix-org/synapse#14149)) - Fix a bug introduced in Synapse 1.58.0 where a user with presence state `org.matrix.msc3026.busy` would mistakenly be set to `online` when calling `/sync` or `/events` on a worker process. ([\#14393](matrix-org/synapse#14393)) - Fix a bug introduced in Synapse 1.70.0 where a receipt's thread ID was not sent over federation. ([\#14466](matrix-org/synapse#14466)) - Fix a long-standing bug where the [List media admin API](https://matrix-org.github.io/synapse/latest/admin_api/media_admin_api.html#list-all-media-in-a-room) would fail when processing an image with broken thumbnail information. ([\#14537](matrix-org/synapse#14537)) - Fix a bug introduced in Synapse 1.67.0 where two logging context warnings would be logged on startup. ([\#14574](matrix-org/synapse#14574)) - In application service transactions that include the experimental `org.matrix.msc3202.device_one_time_key_counts` key, include a duplicate key of `org.matrix.msc3202.device_one_time_keys_count` to match the name proposed by [MSC3202](matrix-org/matrix-spec-proposals#3202). ([\#14565](matrix-org/synapse#14565)) - Fix a bug introduced in Synapse 0.9 where Synapse would fail to fetch server keys whose IDs contain a forward slash. ([\#14490](matrix-org/synapse#14490)) Improved Documentation ---------------------- - Fixed link to 'Synapse administration endpoints'. ([\#14499](matrix-org/synapse#14499)) Deprecations and Removals ------------------------- - Remove legacy Prometheus metrics names. They were deprecated in Synapse v1.69.0 and disabled by default in Synapse v1.71.0. ([\#14538](matrix-org/synapse#14538)) Internal Changes ---------------- - Improve type hinting throughout Synapse. ([\#14055](matrix-org/synapse#14055), [\#14412](matrix-org/synapse#14412), [\#14529](matrix-org/synapse#14529), [\#14452](matrix-org/synapse#14452)). - Remove old stream ID tracking code. Contributed by Nick @beeper (@Fizzadar). ([\#14376](matrix-org/synapse#14376), [\#14468](matrix-org/synapse#14468)) - Remove the `worker_main_http_uri` configuration setting. This is now handled via internal replication. ([\#14400](matrix-org/synapse#14400), [\#14476](matrix-org/synapse#14476)) - Refactor `federation_sender` and `pusher` configuration loading. ([\#14496](matrix-org/synapse#14496)) ([\#14509](matrix-org/synapse#14509), [\#14573](matrix-org/synapse#14573)) - Faster joins: do not wait for full state when creating events to send. ([\#14403](matrix-org/synapse#14403)) - Faster joins: filter out non local events when a room doesn't have its full state. ([\#14404](matrix-org/synapse#14404)) - Faster joins: send events to initial list of servers if we don't have the full state yet. ([\#14408](matrix-org/synapse#14408)) - Faster joins: use servers list approximation received during `send_join` (potentially updated with received membership events) in `assert_host_in_room`. ([\#14515](matrix-org/synapse#14515)) - Fix type logic in TCP replication code that prevented correctly ignoring blank commands. ([\#14449](matrix-org/synapse#14449)) - Remove option to skip locking of tables when performing emulated upserts, to avoid a class of bugs in future. ([\#14469](matrix-org/synapse#14469)) - `scripts-dev/federation_client`: Fix routing on servers with `.well-known` files. ([\#14479](matrix-org/synapse#14479)) - Reduce default third party invite rate limit to 216 invites per day. ([\#14487](matrix-org/synapse#14487)) - Refactor conversion of device list changes in room to outbound pokes to track unconverted rows using a `(stream ID, room ID)` position instead of updating the `converted_to_destinations` flag on every row. ([\#14516](matrix-org/synapse#14516)) - Add more prompts to the bug report form. ([\#14522](matrix-org/synapse#14522)) - Extend editorconfig rules on indent and line length to `.pyi` files. ([\#14526](matrix-org/synapse#14526)) - Run Rust CI when `Cargo.lock` changes. This is particularly useful for dependabot updates. ([\#14571](matrix-org/synapse#14571)) - Fix a possible variable shadow in `create_new_client_event`. ([\#14575](matrix-org/synapse#14575)) - Bump various dependencies in the `poetry.lock` file and in CI scripts. ([\#14557](matrix-org/synapse#14557), [\#14559](matrix-org/synapse#14559), [\#14560](matrix-org/synapse#14560), [\#14500](matrix-org/synapse#14500), [\#14501](matrix-org/synapse#14501), [\#14502](matrix-org/synapse#14502), [\#14503](matrix-org/synapse#14503), [\#14504](matrix-org/synapse#14504), [\#14505](matrix-org/synapse#14505)).

GHA workflow to build complement images of key branches.

05d3ca1

Add changelog.d

240087e

michaelkaye added 2 commits November 21, 2022 17:18

GHA workflow to build complement images of key branches.

d0a007f

Add changelog.d

5fdeac3

michaelkaye force-pushed the michaelk/push_complement_image branch from 240087e to 5fdeac3 Compare November 21, 2022 17:18

Update complement.yml

7f55ed7

Remove special casing for michaelk branch.

michaelkaye marked this pull request as ready for review November 23, 2022 15:30

michaelkaye requested a review from a team as a code owner November 23, 2022 15:30

Merge branch 'develop' into michaelk/push_complement_image

22f1b7e

DMRobertson reviewed Nov 23, 2022

View reviewed changes

.github/workflows/complement.yml Outdated Show resolved Hide resolved

DMRobertson requested a review from a team November 23, 2022 15:32

Update complement.yml

c357525

Should run on master, develop not main, develop

reivilibre suggested changes Nov 24, 2022

View reviewed changes

michaelkaye added 2 commits November 24, 2022 15:20

Rename file to be more obvious

3b2348d

Merge branch 'michaelk/push_complement_image' of github.com:michaelka…

b5f707b

…ye/synapse into michaelk/push_complement_image

michaelkaye requested a review from reivilibre November 24, 2022 15:28

Merge did not go correctly.

45c5fd3

DMRobertson reviewed Nov 24, 2022

View reviewed changes

DMRobertson suggested changes Nov 24, 2022

View reviewed changes

Setup 5am builds of develop, limit to one run at once.

5174c34

michaelkaye requested review from DMRobertson and removed request for reivilibre November 25, 2022 17:00

DMRobertson approved these changes Nov 28, 2022

View reviewed changes

.github/workflows/push_complement_image.yml Outdated Show resolved Hide resolved

Fix crontab---run once at 5AM, not very minute between 5 and 6

ac00139

DMRobertson reviewed Nov 28, 2022

View reviewed changes

.github/workflows/push_complement_image.yml Outdated Show resolved Hide resolved

DMRobertson and others added 4 commits November 28, 2022 12:28

Fix cron syntax again?

22abe0d

Tweak workflow name

7daa053

Allow manual debug runs

608e814

Tweak indentation

95c6943

Ctrl-Alt-L in PyCharm

DMRobertson merged commit 2dad42a into matrix-org:develop Nov 28, 2022

DMRobertson reviewed Nov 28, 2022

View reviewed changes

DMRobertson mentioned this pull request Nov 28, 2022

Fix GHA job for pushing the complement-synapse image #14573

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Push complement image to a docker registry #14509

Push complement image to a docker registry #14509

michaelkaye commented Nov 21, 2022 •

edited

Loading

michaelkaye commented Nov 21, 2022

michaelkaye commented Nov 21, 2022

reivilibre left a comment

reivilibre Nov 24, 2022

Half-Shot Nov 24, 2022

michaelkaye Nov 24, 2022 •

edited

Loading

michaelkaye commented Nov 24, 2022

DMRobertson Nov 24, 2022 •

edited

Loading

DMRobertson left a comment

michaelkaye commented Nov 25, 2022

DMRobertson left a comment

DMRobertson commented Nov 28, 2022

DMRobertson commented Nov 28, 2022

DMRobertson commented Nov 28, 2022

DMRobertson Nov 28, 2022

michaelkaye commented Nov 28, 2022

Push complement image to a docker registry #14509

Push complement image to a docker registry #14509

Conversation

michaelkaye commented Nov 21, 2022 • edited Loading

Pull Request Checklist

michaelkaye commented Nov 21, 2022

michaelkaye commented Nov 21, 2022

reivilibre left a comment

Choose a reason for hiding this comment

reivilibre Nov 24, 2022

Choose a reason for hiding this comment

Half-Shot Nov 24, 2022

Choose a reason for hiding this comment

michaelkaye Nov 24, 2022 • edited Loading

Choose a reason for hiding this comment

michaelkaye commented Nov 24, 2022

DMRobertson Nov 24, 2022 • edited Loading

Choose a reason for hiding this comment

DMRobertson left a comment

Choose a reason for hiding this comment

michaelkaye commented Nov 25, 2022

DMRobertson left a comment

Choose a reason for hiding this comment

DMRobertson commented Nov 28, 2022

DMRobertson commented Nov 28, 2022

DMRobertson commented Nov 28, 2022

DMRobertson Nov 28, 2022

Choose a reason for hiding this comment

michaelkaye commented Nov 28, 2022

michaelkaye commented Nov 21, 2022 •

edited

Loading

michaelkaye Nov 24, 2022 •

edited

Loading

DMRobertson Nov 24, 2022 •

edited

Loading