Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add topic stubs to Synapse Docs #12681

Closed
wants to merge 5 commits into from
Closed

Add topic stubs to Synapse Docs #12681

wants to merge 5 commits into from

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented May 9, 2022

@anoadragon453 and I were discussing how to improve Synapse's developer documentation and we came up with an outline of topics that we would like to see added to the docs. This PR adds those topic stubs to the table of contents, with the hope that the team and contributors alike will then help fill in the stubs and improve the documentation going forwards.

@H-Shay H-Shay requested a review from anoadragon453 May 9, 2022 20:45
@H-Shay H-Shay requested a review from a team as a code owner May 9, 2022 20:45
@H-Shay H-Shay marked this pull request as draft May 9, 2022 20:45
@H-Shay H-Shay removed the request for review from a team May 9, 2022 20:45
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for turning this into a PR Shay!

I would be interested in other's opinions on the topics of the docs laid out here.

Comment on lines +93 to +96
- Flows of data through Synapse
- Starts with a Request/BG Job/Module
- Processing
- Maybe Response
Copy link
Member

@anoadragon453 anoadragon453 May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others should note that the non-markdown links have no effect in SUMMARY.md, and are instead presented here as ideas for headings in pages / general notes.

They are left to give one an idea of what a page may contain, and will be removed/transferred to the parent doc pages before this PR merges.

@MadLittleMods MadLittleMods added A-Docs things relating to the documentation T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels May 11, 2022
- [Storage]()
- What is current database schema?
- Start by linking script that can compile full schema
- Is there a tool that can visualize a postgres db? - Shay to check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this section 👍

Some copy-pastable snippets on how to explore the database would also be nice (cheat sheet):

  • psql synapse: Open the postgres CLI against the synapse database
  • \q -> enter: To quit/exit
  • \dt: list tables
  • \d+ issues: list columns and indexes for issues table
  • CREATE TABLE board_labels();: Create a table called board_labels
  • DROP TABLE insertion_event_extremeties
  • explain SELECT * FROM events WHERE depth = 1;
  • explain analyze SELECT * FROM events WHERE depth = 1;

-- #10245

- How does this work?
- How is this helpful?
- What's jaeger?
- How do I create and mutate a span?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Definitely interested in how to work with and use all of the jaeger stuff!

@clokep
Copy link
Member

clokep commented Jan 25, 2023

@H-Shay, @anoadragon453 Do you think we should land this or close it?

@H-Shay
Copy link
Contributor Author

H-Shay commented Jan 25, 2023

Fair question, I am interested in landing something like this, even if it doesn't go in the developer documentation (I think there were concerns with it becoming overwhelming?). Let's close this for now and maybe I'll flesh out something that could go in contrib or stand on it's own as an overview of Synapse.

@H-Shay H-Shay closed this Jan 25, 2023
@anoadragon453
Copy link
Member

In our Internal Backend Chapter sync, we talked about instead documenting these items as long-form docstrings in the code base. I think this PR served as a good place to drum up ideas of things to document. We could now take it as inspiration for documentation to write alongside the code. For instance, if we want to write about Background Jobs, we should add to the docstring of the _BackgroundProcess class. File headers can have descriptions of the whole file, as well as general topics that cover multiple classes.

I think our current documentation suffers from us not looking at it frequently enough. Whereas if it were more intermixed with the code then we'd come across and update it more frequently.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants