Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove redundant parameters on _check_event_auth #11292

Merged
merged 1 commit into from
Nov 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11292.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unused parameters on `FederationEventHandler._check_event_auth`.
10 changes: 0 additions & 10 deletions synapse/handlers/federation_event.py
Original file line number Diff line number Diff line change
Expand Up @@ -981,8 +981,6 @@ async def _process_received_pdu(
origin,
event,
context,
state=state,
backfilled=backfilled,
)
except AuthError as e:
# FIXME richvdh 2021/10/07 I don't think this is reachable. Let's log it
Expand Down Expand Up @@ -1332,8 +1330,6 @@ async def _check_event_auth(
origin: str,
event: EventBase,
context: EventContext,
state: Optional[Iterable[EventBase]] = None,
backfilled: bool = False,
) -> EventContext:
"""
Checks whether an event should be rejected (for failing auth checks).
Expand All @@ -1344,12 +1340,6 @@ async def _check_event_auth(
context:
The event context.

state:
The state events used to check the event for soft-fail. If this is
not provided the current state events will be used.

backfilled: True if the event was backfilled.

Returns:
The updated context object.

Expand Down
2 changes: 0 additions & 2 deletions tests/test_federation.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ async def _check_event_auth(
origin,
event,
context,
state=None,
backfilled=False,
):
return context

Expand Down