Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor oEmbed previews #10814

Merged
merged 21 commits into from
Sep 21, 2021
Merged

Refactor oEmbed previews #10814

merged 21 commits into from
Sep 21, 2021

Commits on Sep 14, 2021

  1. Factor out calculating a description from an HTML tree.

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    84c4a53 View commit details
    Browse the repository at this point in the history

  2. Factor out calculating the expiration timestamp.

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    160b2ca View commit details
    Browse the repository at this point in the history

  3. Factor out pre-caching a related image.

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    611849d View commit details
    Browse the repository at this point in the history

  4. Update test to actually return an image.

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    05076b7 View commit details
    Browse the repository at this point in the history

  5. Process oEmbed by downloading the result to a file for later processing. 

    This makes oEmbed previews more like image / HTML previews and
takes beter advantage of the caching layer.
    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    0501d08 View commit details
    Browse the repository at this point in the history

  6. Assume required properties exist.

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    0c763bf View commit details
    Browse the repository at this point in the history

  7. Newsfragment

    @clokep
    clokep committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3ffaee6 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Merge remote-tracking branch 'origin/develop' into clokep/oembed-impr… 

    …ovements
    @clokep
    clokep committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    91f5d0c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Rename some variables.

    @clokep
    clokep committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    c98626c View commit details
    Browse the repository at this point in the history

  2. Clarify docs more.

    @clokep
    clokep committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    c29713f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into clokep/oembed-impr… 

    …ovements
    @clokep
    clokep committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    ea0870f View commit details
    Browse the repository at this point in the history

  4. Use png constant.

    @clokep
    clokep committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    e9cf11f View commit details
    Browse the repository at this point in the history

  5. Clearer property names.

    @clokep
    clokep committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    53b733b View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Return early in _precache_image_url.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    86b75fb View commit details
    Browse the repository at this point in the history

  2. Fix charset in tests.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    93c0c25 View commit details
    Browse the repository at this point in the history

  3. Clarify when cache_age is None.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    5327053 View commit details
    Browse the repository at this point in the history

  4. Cap the amount of time which URL previews will be kept to 24 hours.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    a2a40d7 View commit details
    Browse the repository at this point in the history

  5. Fix typo.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    6643b3f View commit details
    Browse the repository at this point in the history

  6. Pass raw-bytes to the oEmbed code.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1f975d6 View commit details
    Browse the repository at this point in the history

  7. Clarify comment. 

    Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
    @clokep @richvdh
    clokep and richvdh committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c31f23b View commit details
    Browse the repository at this point in the history

  8. Re-use a constant.

    @clokep
    clokep committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    62b36c0 View commit details
    Browse the repository at this point in the history