This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
test twisted 21.7 #10402
Closed
test twisted 21.7 #10402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you maybe change the type hints to inline type hints as per this effort? If deferreds give errors on "not subscribable", wrap them in string quotations. |
these should be identical semantically, and since `defer.ensureDeferred` is defined to take a `typing.Coroutine`, will keep mypy happy
richvdh
force-pushed
the
rav/test_twisted_21_7
branch
from
52a2853
to
1496981
Compare
tighten up some of the typing in CachedCall, which is going to be needed when Twisted 21.7 brings better typing on Deferred.
richvdh
force-pushed
the
rav/test_twisted_21_7
branch
from
1496981
to
e2a6fdc
Compare
done. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't merge this at least until 21.7 is properly released, since the type annotation changes will cause mypy to fail on twisted 21.2. For now it just serves as a way to run CI against 21.7.
Based on #10446 and #10450.