Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add a new version of the R30 phone-home metric, which removes a false impression of retention given by the old R30 metric #10332

Merged
merged 24 commits into from
Jul 19, 2021
Merged

Add a new version of the R30 phone-home metric, which removes a false impression of retention given by the old R30 metric #10332

merged 24 commits into from
Jul 19, 2021

Commits on Jul 15, 2021

  1. Add initial R30v2 tests

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    899e7c4 View commit details
    Browse the repository at this point in the history

  2. Allow custom headers (e.g. User-Agent) in some test helpers

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    7a87cbe View commit details
    Browse the repository at this point in the history

  3. Add code to calculate R30v2

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    e106b94 View commit details
    Browse the repository at this point in the history

  4. Tweak and add R30v2 tests

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    98dcf2b View commit details
    Browse the repository at this point in the history

  5. Add R30v2 stats to the phone home data

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    8511e1a View commit details
    Browse the repository at this point in the history

  6. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    248966a View commit details
    Browse the repository at this point in the history

  7. Explicitly report 0 when no clients of that type are present

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    39a3b8f View commit details
    Browse the repository at this point in the history

  8. Remove review question

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    2eda2a7 View commit details
    Browse the repository at this point in the history

  9. Remove some unneeded advances

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    261b6c4 View commit details
    Browse the repository at this point in the history

  10. Apply rename

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    6b6b6f2 View commit details
    Browse the repository at this point in the history

  11. Rewrite R30v2 query to not use window function 

    Window functions are not supported in SQLite before 2018.
    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    fd4f493 View commit details
    Browse the repository at this point in the history

  12. Cast things to BIGINT because poor Postgres cries

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    92d215c View commit details
    Browse the repository at this point in the history

  13. Add alias to make Postgres happy

    @reivilibre
    reivilibre committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    9353939 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Move multiplies to python from SQL

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    6762bcf View commit details
    Browse the repository at this point in the history

  2. Don't bother ordering

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    2fca561 View commit details
    Browse the repository at this point in the history

  3. Simplify WHEN chain

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    80c9187 View commit details
    Browse the repository at this point in the history

  4. Remove review comment

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    79db58b View commit details
    Browse the repository at this point in the history

  5. Clarify desired_time is secs

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    982b2d1 View commit details
    Browse the repository at this point in the history

  6. Factorise out store

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    7860bc9 View commit details
    Browse the repository at this point in the history

  7. Clean up and standardise the advance times

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    a865726 View commit details
    Browse the repository at this point in the history

  8. Describe the structure of the dict

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    44a0f91 View commit details
    Browse the repository at this point in the history

  9. Clean up casts and move multiplications into Python

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    46827cf View commit details
    Browse the repository at this point in the history

  10. Clarify comment about five minutes

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    899251c View commit details
    Browse the repository at this point in the history

  11. Factorise store again (oops)

    @reivilibre
    reivilibre committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    8a4f589 View commit details
    Browse the repository at this point in the history