Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Olddeps: leave a TODO for caret bounds
Browse files Browse the repository at this point in the history
  • Loading branch information
David Robertson committed Mar 31, 2022
1 parent 45a23c0 commit e96fd31
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions .ci/scripts/test_old_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,18 @@ export VIRTUALENV_NO_DOWNLOAD=1
# https://github.com/pypa/pip/issues/8085
# to select the lowest possible versions, rather than resorting to this sed script.

# patch the project definitions in-place
# replace all lower bounds with exact bounds
# but make the pyopenssl 17.0, which can work against an
# OpenSSL 1.1 compiled cryptography (as older ones don't compile on Travis).
# delete all lines referring to psycopg2 --- so no testing of postgres support
# Omit systemd: we're not logging to journal here.
# Patch the project definitions in-place:
# - Replace all lower and tilde bounds with exact bounds
# - Make the pyopenssl 17.0, which can work against an
# OpenSSL 1.1 compiled cryptography (as older ones don't compile on Travis).
# - Delete all lines referring to psycopg2 --- so no testing of postgres support.
# - Omit systemd: we're not logging to journal here.

# TODO: also replace caret bounds, see https://python-poetry.org/docs/dependency-specification/#version-constraints
# We don't use these yet, but IIRC they are the default bound used when you `poetry add`.
# The sed expression 's/\^/==/g' ought to do the trick. But it would also change
# `python = "^3.7"` to `python = "==3.7", which would mean we fail because olddeps
# runs on 3.8 (#12343).

sed -i-backup \
-e "s/[~>]=/==/g" \
Expand Down

0 comments on commit e96fd31

Please sign in to comment.