Fix synapse_event_persisted_position metric

Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`
matrix-org · Apr 6, 2022 · 9888b8b · 9888b8b
1 parent 573cd0f
commit 9888b8b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/12390.bugfix b/changelog.d/12390.bugfix
@@ -0,0 +1 @@
+Fix a bug introduced in Synapse 1.49.0 which caused the `synapse_event_persisted_position` metric to have invalid values.
diff --git a/synapse/storage/databases/main/events.py b/synapse/storage/databases/main/events.py
@@ -197,9 +197,9 @@ async def _persist_events_and_state_updates(
             )
             persist_event_counter.inc(len(events_and_contexts))
 
-            if stream < 0:
-                # backfilled events have negative stream orderings, so we don't
-                # want to set the event_persisted_position to that.
+            if not use_negative_stream_ordering:
+                # we don't want to set the event_persisted_position to a negative
+                # stream_ordering.
                 synapse.metrics.event_persisted_position.set(
                     events_and_contexts[-1][0].internal_metadata.stream_ordering
                 )