Remove redundant parameters on _check_event_auth (#11292)

as of #11012, these parameters are unused.
matrix-org · Nov 10, 2021 · 73cbb28 · 73cbb28
1 parent 68c258a
commit 73cbb28
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/changelog.d/11292.misc b/changelog.d/11292.misc
@@ -0,0 +1 @@
+Remove unused parameters on `FederationEventHandler._check_event_auth`.
diff --git a/synapse/handlers/federation_event.py b/synapse/handlers/federation_event.py
@@ -981,8 +981,6 @@ async def _process_received_pdu(
                 origin,
                 event,
                 context,
-                state=state,
-                backfilled=backfilled,
             )
         except AuthError as e:
             # FIXME richvdh 2021/10/07 I don't think this is reachable. Let's log it
@@ -1332,8 +1330,6 @@ async def _check_event_auth(
         origin: str,
         event: EventBase,
         context: EventContext,
-        state: Optional[Iterable[EventBase]] = None,
-        backfilled: bool = False,
     ) -> EventContext:
         """
         Checks whether an event should be rejected (for failing auth checks).
@@ -1344,12 +1340,6 @@ async def _check_event_auth(
             context:
                 The event context.
 
-            state:
-                The state events used to check the event for soft-fail. If this is
-                not provided the current state events will be used.
-
-            backfilled: True if the event was backfilled.
-
         Returns:
             The updated context object.
 

diff --git a/tests/test_federation.py b/tests/test_federation.py
@@ -81,8 +81,6 @@ async def _check_event_auth(
             origin,
             event,
             context,
-            state=None,
-            backfilled=False,
         ):
             return context