Do not install setuptools 50.0. (#8212)

This is due to compatibility issues with old Python versions.
matrix-org · Sep 1, 2020 · 318245e · 318245e
1 parent aa07c37
commit 318245e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/INSTALL.md b/INSTALL.md
@@ -73,7 +73,7 @@ mkdir -p ~/synapse
 virtualenv -p python3 ~/synapse/env
 source ~/synapse/env/bin/activate
 pip install --upgrade pip
-pip install --upgrade setuptools
+pip install --upgrade setuptools!=50.0  # setuptools==50.0 fails on some older Python versions
 pip install matrix-synapse
 ```
 

diff --git a/changelog.d/8212.bugfix b/changelog.d/8212.bugfix
@@ -0,0 +1 @@
+Do not install setuptools 50.0. It can lead to a broken configuration on some older Python versions.
diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py
@@ -74,6 +74,10 @@
     "Jinja2>=2.9",
     "bleach>=1.4.3",
     "typing-extensions>=3.7.4",
+    # setuptools is required by a variety of dependencies, unfortunately version
+    # 50.0 is incompatible with older Python versions, see
+    # https://github.com/pypa/setuptools/issues/2352
+    "setuptools!=50.0",
 ]
 
 CONDITIONAL_REQUIREMENTS = {