Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove the unspecced room_id field in the /hierarchy response. (#13506)
Browse files Browse the repository at this point in the history
This is a re-do of 57d334a (#13365),
which was backed out in 12abd72 (#13501).

The `room_id` field represented the parent space for each room
and was made redundant by changes in the API shape where the
`children_state` is now nested underneath each `room`.

The room ID of each child is in the `state_key` field and is still
available.
  • Loading branch information
reivilibre committed Sep 6, 2022
1 parent c9b7e97 commit 26bc265
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/13506.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.41.0 where the `/hierarchy` API returned non-standard information (a `room_id` field under each entry in `children_state`).
1 change: 0 additions & 1 deletion synapse/handlers/room_summary.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ async def _summarize_local_room(
"type": e.type,
"state_key": e.state_key,
"content": e.content,
"room_id": e.room_id,
"sender": e.sender,
"origin_server_ts": e.origin_server_ts,
}
Expand Down

0 comments on commit 26bc265

Please sign in to comment.