GHA job to check newsfragments. #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/check_newsfragment_action
branch
from
b3a5de8
to
7895705
Compare
turt2live
approved these changes
Mar 8, 2022
|
yeah I was thinking a label or somesuch. Not wild about having to make a newsfile that's going to get thrown away. |
richvdh
added a commit
that referenced
this pull request
Mar 9, 2022
Turns out this check, introduced in #990, didn't actually work right.
Merged
richvdh
added a commit
that referenced
this pull request
Mar 9, 2022
Turns out this check, introduced in #990, didn't actually work right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having just found another three newsfragments in the wrong places, I cracked and wrote a CI job to check.
Ironically, this PR is failing CI, because it doesn't have a changelog. That doesn't happen very often, so I'm inclined to ignore it, but I'm open to suggestions for ways to flag/detect PRs that don't need a changelog.