Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for MSC2746 #1511

Merged
merged 38 commits into from
May 23, 2023
Merged

Add spec for MSC2746 #1511

merged 38 commits into from
May 23, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 4, 2023

@dbkr dbkr added the A-VoIP label May 4, 2023
@dbkr dbkr requested a review from a team as a code owner May 4, 2023 11:12
@turt2live turt2live added the release-blocker Blocks the next release from happening label May 16, 2023
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
content/client-server-api/modules/voip_events.md Outdated Show resolved Hide resolved
call_id:
type: string
description: The ID of the call this event relates to.
version:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be worthwhile to factor out the call_id, version, and party_id fields into a file that could be included in all the voip events. Maybe a core-event-schema/voip_event.yaml file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is neater. The only downside is that it repeats all the fields from a room event and I'm not sure how to make it not do that.

data/event-schemas/schema/m.call.invite.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
data/event-schemas/schema/m.call.negotiate.yaml Outdated Show resolved Hide resolved
dbkr and others added 4 commits May 17, 2023 09:43
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
dbkr and others added 9 commits May 17, 2023 09:48
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
I confused myself, but it's not in the MSC and it shouldn't be.
@dbkr dbkr requested a review from uhoreg May 17, 2023 13:56
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo some suggestions

dbkr and others added 3 commits May 23, 2023 13:33
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Co-authored-by: Hubert Chathi <hubertc@matrix.org>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the build

data/event-schemas/schema/m.call.select_answer.yaml Outdated Show resolved Hide resolved
@turt2live
Copy link
Member

Looks like all threads are resolved here - merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP release-blocker Blocks the next release from happening
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants