Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC4159: Remove the deprecated name attribute on HTML anchor elements #4159

Merged
merged 1 commit into from
Jul 8, 2024
Merged

MSC4159: Remove the deprecated name attribute on HTML anchor elements #4159

merged 1 commit into from
Jul 8, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Jun 20, 2024 •
edited by turt2live
Loading

Rendered

Relates to: matrix-org/matrix-spec#1790, matrix-org/matrix-spec#1870

In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am a Systems Architect at gematik, Software Engineer at Unomed, Matrix community member and former Element employee. This proposal was written and published with my community member hat on.

FCP tickyboxes

@Johennes Johennes force-pushed the johannes/remove-anchor-name branch from e65ff4e to c02fb93 Compare June 20, 2024 13:09
@Johennes Johennes changed the title MSCXXXX: Remove the deprecated name attribute on HTML anchor elements MSC4159: Remove the deprecated name attribute on HTML anchor elements Jun 20, 2024
@Johennes
MSC4159: Remove the deprecated name attribute on HTML anchor elements
f39e6cf 
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/remove-anchor-name branch from c02fb93 to f39e6cf Compare June 20, 2024 13:10
@Johennes Johennes mentioned this pull request Jun 20, 2024
Merged
3 tasks
@Johennes Johennes marked this pull request as ready for review June 20, 2024 13:11
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jun 20, 2024
turt2live
turt2live reviewed Jun 20, 2024
View reviewed changes
proposals/4159-remove-anchor-name.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:

  • None, in my opinion. It's hard to implement something which clients don't [appear to] use.

@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 20, 2024
@turt2live
Copy link
Member

I asked for this MSC primarily to see if there's folks out there using this at all, and if they'd be sad to see it go. In the interest of not delaying the process needlessly for that to happen:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jun 20, 2024 •
edited by ara4n
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Jun 20, 2024
@mscbot
Copy link
Collaborator

mscbot commented Jul 2, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 2, 2024
@mscbot
Copy link
Collaborator

mscbot commented Jul 7, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jul 7, 2024
@turt2live turt2live merged commit bbe54bc into matrix-org:main Jul 8, 2024
1 check passed
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1870

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Jul 8, 2024
@uhoreg
Copy link
Member

uhoreg commented Jul 10, 2024

Merged! 🎉

@uhoreg uhoreg added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jul 10, 2024
This was referenced Sep 5, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

Assignees
No one assigned
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Johennes @turt2live @mscbot @uhoreg