Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC4120: Allow HEAD on /download #4120

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

turt2live
Copy link
Member

Rendered

In line with matrix-org/matrix-spec#1700, the following disclosure applies:

I am Director of Standards Development at The Matrix.org Foundation C.I.C., Matrix Spec Core Team (SCT) member, employed by Element, and operate the t2bot.io service. This proposal is written and published under my Element hat as a member of the Trust & Safety team, allocated to the Foundation.

@turt2live turt2live changed the title MSC: Allow HEAD on /download MSC4120: Allow HEAD on /download Mar 21, 2024
@turt2live turt2live marked this pull request as ready for review March 21, 2024 17:11
@turt2live turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Mar 21, 2024
Copy link
Member Author

@turt2live turt2live Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation requirements:


## Proposal

`HEAD` becomes a legal request method on the following endpoints:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some words on whether we expect HEAD to be unauthenticated, authenticated, or match their GET counterparts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implied through the HTTP spec, I believe. HEAD matches GET, and would be authenticated when GET is also authenticated.

turt2live added a commit to t2bot/matrix-media-repo that referenced this pull request Mar 28, 2024
turt2live added a commit to t2bot/matrix-media-repo that referenced this pull request Mar 28, 2024
* Support `HEAD` on `/download`, per MSC4120

matrix-org/matrix-spec-proposals#4120

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:core MSC which is critical to the protocol's success needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants