Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify how to handle multiple olm sessions with the same device #1596

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Aug 29, 2018

Fixes #892

use the session from which it last received a message. A client may expire old
sessions by defining a maximum number of olm sessions that it will maintain for
each device, and expiring sessions on a Least Recently Used basis. The maximum
number of olm sessions maintained per device should be at least 4.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if 4 is the right number here, but I think that it will handle the case where two clients keep alternating between two sessions because they send each other messages at the same time, and then they both decide that they need to start new sessions (e.g. because the old sessions are wedged).

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is looking to spec something sane, rather than what is currently implemented? (because I'm pretty sure this is not what is implemented).

If so, it lgtm.

@richvdh richvdh assigned uhoreg and unassigned richvdh Aug 29, 2018
@uhoreg
Copy link
Member Author

uhoreg commented Aug 30, 2018

Yup, the current behaviour does not match the proposed spec, so the behaviour will need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants