Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests: update instructions #4017

Merged
merged 2 commits into from
Sep 18, 2024
Merged

integration tests: update instructions #4017

merged 2 commits into from
Sep 18, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Sep 18, 2024

  • explain what these tests are
  • mention that it's sometimes needed to rebuild the synapse image

@bnjbvr
integration tests: update instructions
72a02c2 
- explain what these tests are
- mention that it's sometimes needed to rebuild the synapse image
@bnjbvr bnjbvr requested a review from a team as a code owner September 18, 2024 13:42
@bnjbvr bnjbvr requested review from stefanceriu and removed request for a team September 18, 2024 13:42
Hywan
Hywan approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah B-)

testing/matrix-sdk-integration-testing/README.md Outdated Show resolved Hide resolved
@Hywan Hywan removed the request for review from stefanceriu September 18, 2024 13:46
@bnjbvr @Hywan
Update testing/matrix-sdk-integration-testing/README.md
2da0fec 
Co-authored-by: Ivan Enderlin <ivan@mnt.io>
Signed-off-by: Benjamin Bouvier <benjamin@bouvier.cc>
@bnjbvr bnjbvr enabled auto-merge (squash) September 18, 2024 14:31
@bnjbvr bnjbvr enabled auto-merge (squash) September 18, 2024 14:36
@bnjbvr bnjbvr merged commit 1b4f665 into main Sep 18, 2024
40 checks passed
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (f576c72) to head (2da0fec).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4017      +/-   ##
==========================================
- Coverage   84.27%   84.24%   -0.03%     
==========================================
  Files         266      266              
  Lines       28336    28336              
==========================================
- Hits        23880    23872       -8     
- Misses       4456     4464       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr deleted the bnjbvr/update-integration-test-readme branch September 18, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnjbvr @Hywan