-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry decryption of UTD timeline items #1215
Conversation
Not really necessary now, but required for thread-safe bulk updates like we want for retrying decryption.
Codecov ReportBase: 74.57% // Head: 74.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 74.57% 74.49% -0.08%
==========================================
Files 112 112
Lines 12800 12878 +78
==========================================
+ Hits 9545 9594 +49
- Misses 3255 3284 +29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, your call if you want to add the retry on import right away.
// Not using room.add_event_handler here because RoomKey events are | ||
// to-device events that are not received in the context of a room. | ||
let room_id = room.room_id().to_owned(); | ||
let room_key_handle = room.client.add_event_handler({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to note here, this is not the only source of room keys. As your test shows there's at least one other source.
In total we have three sources:
- Receive them over to-device
- Manually import them from a file
- Import them from a backup
Your tests is using no. 2, no. 3 is another variant of 2 but not yet implemented.
I'm fine with opening an issue for this and linking to it, though adding some way for the RoomKeyImportResult
to trigger a retry_event_decryption()
call shouldn't be terribly complex either.
No description provided.