Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Revert "add labels to language picker" #994

Merged
merged 1 commit into from
Jun 1, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/views/elements/LanguageDropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ export default class LanguageDropdown extends React.Component {
}

componentWillMount() {
languageHandler.getAllLanguagesFromJson().then((langs) => {
languageHandler.getAllLanguageKeysFromJson().then((langKeys) => {
const langs = [];
langKeys.forEach((languageKey) => {
langs.push({
value: languageKey,
label: _t(languageKey)
});
});
langs.sort(function(a, b){
if(a.label < b.label) return -1;
if(a.label > b.label) return 1;
Expand Down
19 changes: 5 additions & 14 deletions src/languageHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export function setLanguage(preferredLangs) {
throw new Error("Unable to find an appropriate language");
}

return getLanguage(i18nFolder + availLangs[langToUse].fileName);
return getLanguage(i18nFolder + availLangs[langToUse]);
}).then((langData) => {
counterpart.registerTranslations(langToUse, langData);
counterpart.setLocale(langToUse);
Expand All @@ -142,25 +142,16 @@ export function setLanguage(preferredLangs) {

// Set 'en' as fallback language:
if (langToUse != "en") {
return getLanguage(i18nFolder + availLangs['en'].fileName);
return getLanguage(i18nFolder + availLangs['en']);
}
}).then((langData) => {
if (langData) counterpart.registerTranslations('en', langData);
});
};

export function getAllLanguagesFromJson() {
return getLangsJson().then((langsObject) => {
var langs = [];
for (var langKey in langsObject) {
if (langsObject.hasOwnProperty(langKey)) {
langs.push({
'value': langKey,
'label': langsObject[langKey].label
});
}
}
return langs;
export function getAllLanguageKeysFromJson() {
return getLangsJson().then((langs) => {
return Object.keys(langs);
});
}

Expand Down