This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Matthew/room avatar event #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
suggested changes
Jun 1, 2017
| limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; |
There was a problem hiding this comment.
These can go away now, they are implicit.
|
|
||
| 'use strict'; | ||
|
|
||
| var React = require('react'); |
There was a problem hiding this comment.
Can we stick to import in new code?
| ); | ||
| } | ||
|
|
||
| var url = ContentRepo.getHttpUriForMxc( |
There was a problem hiding this comment.
I can't really tell in what situations one is supposed to use client.mxcUrlToHttp vs. ContentRepo.getHttpUriForMxc but we're using them both interchangeably here which seems wrong.
There was a problem hiding this comment.
one's the raw download content, the other's a thumbnail. i think it's just how the API is.
src/TextForEvent.js
Outdated
| @@ -17,6 +17,7 @@ limitations under the License. | |||
| var MatrixClientPeg = require("./MatrixClientPeg"); | |||
| var CallHandler = require("./CallHandler"); | |||
| import { _t } from './languageHandler'; | |||
| import sdk from './index'; | |||
|
applied changes; going to assume there was an implicit lgtm O:-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.