Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix vector-im/riot-web#4042 #947

Merged
merged 2 commits into from
May 27, 2017
Merged

Fix vector-im/riot-web#4042 #947

merged 2 commits into from
May 27, 2017

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented May 27, 2017

No description provided.

@matrixbot
Copy link
Member

Can one of the admins verify this patch?

t3chguy
t3chguy approved these changes May 27, 2017
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
for next time though, single character param names are useless, just means you have to look over the whole fn instead of the signature being enough when extending the file.

@ara4n ara4n merged commit 02c2930 into matrix-org:develop May 27, 2017
@MTRNord MTRNord deleted the patch-1 branch May 27, 2017 22:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MTRNord @matrixbot @t3chguy @ara4n