This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Make the linked versions open a new tab, turt2live complained :P #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Can one of the admins verify this patch? |
dbkr
suggested changes
May 23, 2017
| @@ -46,7 +46,7 @@ const gHVersionLabel = function(repo, token='') { | |||
| } else { | |||
| url = `https://github.com/${repo}/commit/${token.split('-')[0]}`; | |||
| } | |||
| return <a href={url}>{token}</a>; | |||
| return <a target="_blank" href={url}>{token}</a>; | |||
There was a problem hiding this comment.
We need to be very careful with target="_blank" as per https://mathiasbynens.github.io/rel-noopener/ (tl;dr, add rel="noopener")
There was a problem hiding this comment.
<a target="_blank" rel="noopener"> is what you want
There was a problem hiding this comment.
oh wow, shows how tired I am xD
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/version_anchor_newtab
branch
from
591e1b6
to
a10c2fa
Compare
dbkr
approved these changes
May 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.