Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Display view source toggle on IRC layout #9066

Closed
wants to merge 2 commits into from
Closed

Display view source toggle on IRC layout #9066

wants to merge 2 commits into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 17, 2022

Fixes element-hq/element-web#22872

Before After
before after
↑ Against develop branch

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

type: defect

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

🐛 Bug Fixes

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jul 17, 2022
@luixxiul luixxiul marked this pull request as ready for review July 17, 2022 11:32
@luixxiul luixxiul requested a review from a team as a code owner July 17, 2022 11:32
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlaps with read receipt:
Screenshot 2022-07-18 at 10 21 54

Clips out of message area, leaving very small clickable area:
Screenshot 2022-07-18 at 10 22 35

In message bubbles, overlaps with reactions:
(This one looks pretty bad on develop already, but at least doesn't overlap)
Screenshot 2022-07-18 at 10 27 38

@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 19, 2022

@kerryarchibald

Overlaps with read receipt: Screenshot 2022-07-18 at 10 21 54

It should be fixed once #9058 lands.

Clips out of message area, leaving very small clickable area:

This is a separate issue, which not only is applied to IRC layout but also modern/group layout and bubble layout.

It should be addressed with another PR.

In message bubbles, overlaps with reactions: (This one looks pretty bad on develop already, but at least doesn't overlap)

This is also a separate issue. This PR only changes _IRCLayout.pcss.

Except fixing a conflict, I believe there is nothing to change on this PR.

@kerryarchibald
Copy link
Contributor

Will rereview after #9058 lands to check the read receipt overlap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View source toggle is not displayed on IRC layout
2 participants