Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prevent an exception getting scroll node #902

Merged
merged 2 commits into from
May 18, 2017

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 18, 2017

Don't try to findDOMNode before we're mounted as it makes react
angry.

dbkr added 2 commits May 18, 2017 17:33
Don't try to findDOMNode before we're mounted as it makes react
angry.
Copy link
Contributor

@lukebarnard1 lukebarnard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it pains me slightly how much we're using findDomNode

@dbkr
Copy link
Member Author

dbkr commented May 18, 2017

If that pains you, best not look at how the sticky headers are done. :)

@dbkr dbkr merged commit 726cd60 into develop May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants