This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
MessageComposerButtons: code cleanup, move buttons out of dropdown #8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
|
@ckiee It looks to me that you're working on the 'new' message composer which was redacted recently due to a lot of regressions... Is it intentional? Or does it not really matter here? |
Oops. I hadn't pulled on (Also, I love the use of redacted in "which was redacted recently". You are immersed in the Matrix.) |
Signed-off-by: ckie <git-525ff67@ckie.dev>
…e mode Signed-off-by: ckie <git-525ff67@ckie.dev>
…n in wide mode" This reverts commit 5fd0906.
github-actions
bot
added
the
T-Enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're in wide mode, we might away steal a bit more space from the text input to save a click for users.
There's 3 options in this PR:
Opinions? I think #2 is too overloaded.
Notes: TBD
Type: enhancement
Here's what your changelog entry will look like:
✨ Features