Fix: AccessibleButton does not set disabled attribute (PSF-1055)

res/css/components/views/location/_ShareType.scss

@@ -63,14 +63,6 @@ limitations under the License.
     &:hover, &:focus {
         border-color: $accent;
     }
-
-    // this style is only during active development
-    // when lab is enabled but feature not fully implemented
-    // pin drop option will be disabled
-    &.mx_AccessibleButton_disabled {
-        pointer-events: none;
-        opacity: 0.4;
-    }
 }
 
 .mx_ShareType_option-icon {

src/components/views/location/LocationPicker.tsx

@@ -204,6 +204,11 @@ class LocationPicker extends React.Component<ILocationPickerProps, IState> {
     };
 
     private onOk = () => {
+        // disabling button doesn't stop its handler
+        // don't submit without a position
+        if (!this.state.position) {
+            return;
+        }
         const { timeout, position } = this.state;
 
         this.props.onChoose(

test/components/views/location/LocationPicker-test.tsx

@@ -186,6 +186,28 @@ describe("LocationPicker", () => {
                     expect(wrapper.find('MemberAvatar').length).toBeTruthy();
                 });
 
+                it('disables submit button until geolocation completes', () => {
+                    const onChoose = jest.fn();
+                    const wrapper = getComponent({ shareType, onChoose });
+
+                    // submit button is enabled when position is truthy
+                    expect(findByTestId(wrapper, 'location-picker-submit-button').at(0).props().disabled).toBeTruthy();
+                    act(() => {
+                        findByTestId(wrapper, 'location-picker-submit-button').at(0).simulate('click');
+                    });
+                    // nothing happens on button click
+                    expect(onChoose).not.toHaveBeenCalled();
+
+                    act(() => {
+                        // @ts-ignore
+                        mocked(mockGeolocate).emit('geolocate', mockGeolocationPosition);
+                        wrapper.setProps({});
+                    });
+
+                    // submit button is enabled when position is truthy
+                    expect(findByTestId(wrapper, 'location-picker-submit-button').at(0).props().disabled).toBeFalsy();
+                });
+
                 it('submits location', () => {
                     const onChoose = jest.fn();
                     const wrapper = getComponent({ onChoose, shareType });