-
-
Notifications
You must be signed in to change notification settings - Fork 832
Added TextInputWithCheckbox dialog #868
Added TextInputWithCheckbox dialog #868
Conversation
It's going to be great for people running their own home servers to have this setting available in the UI 💪 One suggestion/idea: Probably it would make sense to also add an element in the room settings panel which shows the status of the |
Yes, you are right. In fact both PR are part of the same feature.
…On 8 May 2017 10:06 p.m., "Adrian Perez" ***@***.***> wrote:
It's going to be great for people running their own home servers to have
this setting available in the UI 💪
One suggestion/idea: Probably it would make sense to also add an element
in the room settings panel which shows the status of the m.federate flag
as part of this set of PRs (I am not sure whether that would go here or as
part of element-hq/element-web#3849
<element-hq/element-web#3849> though). Without
something like that there is no way of knowing whether a room was created
as federatable or not without checking with the HTTP API manually, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#868 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXABhGAFRHZ-Fdc2TQEwU4sc7O_maNIks5r33W2gaJpZM4NTwoO>
.
|
would fix element-hq/element-web#1669 |
@aperezdc riot-web Room Settings already shows a message if |
… set_default_federate_by_settings
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
From conversation in riot-dev, needs an |
…t_federate_by_settings # Conflicts: # src/components/structures/MatrixChat.js
I'm thinking that the advanced option should mention m.federate explicitly as its wording is somewhat ambiguous |
… set_default_federate_by_settings
sorry that this has been stuck for so long, and huge thanks for submitting it (and @t3chguy for pushing it through). part of the stuckness has been due to confusion on whether this actually means to check the synapse API or not (and whether that API shape is okay). However, given it just goes off the riot config for now, the concern was confused. However, the tests are failing due to:
If fixed, i'll merge. thanks again. |
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
One more data point supporting the merge of this PR: Our self hosted Riot instance has had this patch set since applied to it by @psaavedra to all Riot releases since last May, and it has been working well. That is a few months of testing 😉 |
@ara4n PTAL |
LGTM (given @ara4n was OK to merge pending linting) |
This change allows change the default value for
m.federate
value during the create action. Useful for enviroments where you preferm.federate = False
asdefault
choice for the created rooms (see related PR).This PR is embraces the following SPEC: https://docs.google.com/document/d/14zqsbwl5KKil-bB8w2HMhidBVmFkP9Q7EQKFwKIIfZc/edit#heading=h.eipip5qhqo0dOther PR in synapse and matrix-js-sdk and riot-web are envolvedSigned-off-by: Pablo Saavedra psaavedra@igalia.com
Related PR:
Edited by Michael to match what the PR actually entails rather than the entire movement that it began as